<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><br></div><div dir="ltr">Hi<br><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 16, 2015 at 4:03 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">So mainly this function has to return always TRUE (success).<br>
<br>
Why not ignoring the return value?<br>
Or returning void?<br>
<span class=""><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"><br>
Frediano<br>
</span></span></blockquote></div><br></div><div class="gmail_extra">The function that calls this one (dcc_handle_message()) looks like this:<br><div><br></div> switch (type) {<br> case SPICE_MSGC_DISPLAY_INIT:<br> return dcc_handle_init(dcc, (SpiceMsgcDisplayInit *)msg);<br> case SPICE_MSGC_DISPLAY_STREAM_REPORT:<br> return dcc_handle_stream_report(dcc, (SpiceMsgcDisplayStreamReport *)msg);<br> case SPICE_MSGC_DISPLAY_PREFERRED_COMPRESSION:<br> return dcc_handle_preferred_compression(dcc,<br> (SpiceMsgcDisplayPreferredCompression *)msg);<br> default:<br> return red_channel_client_handle_message(rcc, size, type, msg);<br> }<br><div><br></div></div><div class="gmail_extra">Always returning TRUE is the same, as removing the return from case<br>SPICE_MSGC_DISPLAY_PREFERRED_COMPRESSION, and return TRUE at the end of this function.<br clear="all"></div><div class="gmail_extra"><br></div><div class="gmail_extra">Always returning TRUE seems nicer to me, because it doesn't break the symmetry in the switch.<br>-- <br><div class="gmail_signature">Lukas Venhoda</div>
</div></div></div>
</blockquote><div>Sounds reasonable<br></div><div><br></div><div>Acked-by: Frediano Ziglio <fziglio@redhat.com><br></div><div><br></div><div>Frediano<br></div><div><br></div></div></body></html>