<div dir="ltr">Hi<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 2:07 PM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hey,<br><div><div class="h5">
<br>
</div></div>Rather than having #ifndef everywhere, I think this bit could be changed<br>
to<br>
<span class="">+#ifndef WORDS_BIGENDIAN<br>
      saved_want_original = want_original;<br>
</span>+#else<br>
<span class="">+        /* On BE machines, we want to explicitly convert the surface all the time */<br>
</span>+     saved_want_original = TRUE;<br>
+#endif<br>
<br></blockquote><div><br></div><div>Yes, I will change that<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I'm wondering if this could cause issues when blitting transparent<br>
surfaces to a 16bpp canvas, as the canvas_get_image_internal documentation<br>
mentions this as a usecase (and the only caller with want_original =<br>
TRUE is canvas_draw_alpha_blend)<br>
(NB: my understanding is that "want_original" really means<br>
"keep_original_image_format")<br>
<br></blockquote><div><br></div><div>I'll try to test the 16bpp again on Win7, because WinXP 16bpp had it's own weird issues.<br></div><div>But from what I understand, it shouldn't be an issue, because setting want_original to TRUE<br>will just convert the canvas to the correct one when using canvas_draw_alpha_blend() anyway right?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Christophe<span class=""></span><br>
</blockquote></div><br>-- <br><div class="gmail_signature">Lukas Venhoda</div>
</div></div>