[Swfdec] Patches to Fix Warnings

Jeffrey C. Ollie jeff at ocjtech.us
Thu Mar 22 10:43:15 PDT 2007


I've been looking at packaging swfdec on my Fedora 6 system.
Unfortunately since a git source checkout compiles with -Werror I've
been having problems because of all of the unused parameter warnings.

I've developed some patches that eliminate the problem by marking all of
the unused parameters with __attribute__ ((unused)).  The attribute
markings are all macroized so if you aren't using GCC to compile the
macro is just a no-op.  There's also a warning of a deprecated function
generated by the ffmpeg, I've included a patch for that too.

Note that these patches compile, but haven't been tested.
swfdec_marshal.c generates unused parameter warnings but since it's
generated code I can't fix it with a patch to swfdec.  I'll probably
start out by substituting a manually patched copy during my local build
until I can work with the upstream author of the tool that generates the
code to fix the problem there.  It might take me a while to get to the
point where I can do some testing since I only have a limited time each
day to work on this.

Anyway, I've put up a git repository with my changes here:

http://git.ocjtech.us/?p=swfdec;a=summary

I'm a bit of a git newbie so I may have done something not quite right
in setting up this repository.

Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/swfdec/attachments/20070322/df8c851c/attachment.pgp


More information about the Swfdec mailing list