<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - sd-daemon.c: include POSIX fcntl.h rather than OS-specific sys/fcntl.h"
href="https://bugs.freedesktop.org/show_bug.cgi?id=63423">63423</a>
</td>
</tr>
<tr>
<th>CC</th>
<td>matt.fischer@garmin.com
</td>
</tr>
<tr>
<th>Assignee</th>
<td>systemd-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>sd-daemon.c: include POSIX fcntl.h rather than OS-specific sys/fcntl.h
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>systemd-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Reporter</th>
<td>simon.mcvittie@collabora.co.uk
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Component</th>
<td>general
</td>
</tr>
<tr>
<th>Product</th>
<td>systemd
</td>
</tr></table>
<p>
<div>
<pre>On <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - QNX Support"
href="show_bug.cgi?id=61176">Bug #61176</a>, Matt Fischer points out that QNX does not have the
popular-but-non-standard header <sys/fcntl.h>, only the "official" POSIX
<fcntl.h>. This broke libdbus builds in the embedded copy of sd-daemon.c (which
we should probably get rid of, but that's not the point right now). Matt said
he'd open a systemd bug, but I couldn't find one, so I'm opening this.
sd-daemon.c currently does this:
#ifdef __BIONIC__
# include <linux/fcntl.h>
#else
# include <sys/fcntl.h>
#endif
but if we used <fcntl.h> we shouldn't need the ugly conditional, unless there's
some special reason why you prefer the OS-specific version - more contents or
something?
libdbus already uses #include <fcntl.h> in its other Unix-specific files, so
this is at least as portable as D-Bus - in particular, it compiles on Android.
Given the sort of esoteric platforms I've heard about people putting D-Bus on,
I think we can safely assume that <fcntl.h> is portable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>