<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - logind writes out session state file before creating fifo so users end up in CLOSING state" href="https://bugs.freedesktop.org/show_bug.cgi?id=67273#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - logind writes out session state file before creating fifo so users end up in CLOSING state" href="https://bugs.freedesktop.org/show_bug.cgi?id=67273">bug 67273</a> from <a class="email" href="mailto:rstrode@redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> Ray Strode [halfline]</a> <pre>(In reply to <a href="show_bug.cgi?id=67273#c3">comment #3</a>) > No it will briefly have "OPENING" in it. See session_get_state(): it will > return OPENING if there's the scope job still pending. The problem was > simply that we saved the state at a time where the scope job was finished > but the fifo not set up yet... Ah okay. When I first started looking into this issue with dwalsh, I was originally looking at a stale git source checkout, and the behavior didn't match what I was reading, so I updated the tree, and then pretty soon after we saw the fifo_fd problem in the code. The last time I read the session_get_state() function I was looking at the stale source before updating, and it didn't have an OPENING state. > > 2) you send out the reply before saving the state file, so, in theory, > > there's a small race where a client could get the reply and then proceed to > > check the state file and still read stale information. It's a pretty small > > race though. > > Hmm, so that's indeed something to fix! > > Done so now in 7c6e214aeb141e6d514ddd9237a956278c4afc8c. cool.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>