<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - logind writes out session state file before creating fifo so users end up in CLOSING state" href="https://bugs.freedesktop.org/show_bug.cgi?id=67273#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - logind writes out session state file before creating fifo so users end up in CLOSING state" href="https://bugs.freedesktop.org/show_bug.cgi?id=67273">bug 67273</a> from <a class="email" href="mailto:lennart@poettering.net" title="Lennart Poettering <lennart@poettering.net>"> Lennart Poettering</a> <pre>(In reply to <a href="show_bug.cgi?id=67273#c2">comment #2</a>) > Looks fine, thanks! > > Two comments, but these things probably don't matter that much in practice: > > 1) the state file will briefly begin its life with CLOSING written in it, > which isn't really accurate, though maybe that's inconsequential. No it will briefly have "OPENING" in it. See session_get_state(): it will return OPENING if there's the scope job still pending. The problem was simply that we saved the state at a time where the scope job was finished but the fifo not set up yet... > 2) you send out the reply before saving the state file, so, in theory, > there's a small race where a client could get the reply and then proceed to > check the state file and still read stale information. It's a pretty small > race though. Hmm, so that's indeed something to fix! Done so now in 7c6e214aeb141e6d514ddd9237a956278c4afc8c. Thanks for have a closer look, much appreciated!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>