<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=77271#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=77271">bug 77271</a>
from <span class="vcard"><a class="email" href="mailto:lennart@poettering.net" title="Lennart Poettering <lennart@poettering.net>"> <span class="fn">Lennart Poettering</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=77271#c15">comment #15</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=100447" name="attach_100447" title="updated patch">attachment 100447</a> <a href="attachment.cgi?id=100447&action=edit" title="updated patch">[details]</a></span>
> updated patch
>
> Here is the updated patch.
> Is it ok like that?</span >
Please follow the usual coding style: no redundant {} in single-line if blocks.
Only spaces, no tabs.
The strsep loop looks needlessly complex. Why not just use "while ((cap =
strsep(...)) { .."?
Otherwise looks OK.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>