<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=77271#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=77271">bug 77271</a>
from <span class="vcard"><a class="email" href="mailto:andy.melnikov@gmail.com" title="Andy Melnikov <andy.melnikov@gmail.com>"> <span class="fn">Andy Melnikov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=100513" name="attach_100513" title="new updated patch">attachment 100513</a> <a href="attachment.cgi?id=100513&action=edit" title="new updated patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=77271&attachment=100513'>[review]</a>
new updated patch
Review of <span class=""><a href="attachment.cgi?id=100513" name="attach_100513" title="new updated patch">attachment 100513</a> <a href="attachment.cgi?id=100513&action=edit" title="new updated patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=77271&attachment=100513'>[review]</a>:
-----------------------------------------------------------------
::: src/shared/virt.c
@@ +170,2 @@
<span class="quote">> if (r >= 0) {
> + while (cap = strsep(&domcap, ",")) {</span >
Shouldn't char * cap = NULL be moved here inside if?
@@ +170,3 @@
<span class="quote">> if (r >= 0) {
> + while (cap = strsep(&domcap, ",")) {
> + if (streq(cap, "control_d"))</span >
Can this be moved above into while condition?
while (cap = strsep(&domcap, ",") && !streq(cap, "control_d")) {</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>