<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - sysv-generator incorrectly handles sysv services that require network-online: it makes network-online.target Want those services, causing them to be started unexpectedly"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=80537#c1">Comment # 1</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - sysv-generator incorrectly handles sysv services that require network-online: it makes network-online.target Want those services, causing them to be started unexpectedly"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=80537">bug 80537</a>
              from <span class="vcard"><a class="email" href="mailto:awilliam@redhat.com" title="Adam Williamson <awilliam@redhat.com>"> <span class="fn">Adam Williamson</span></a>
</span></b>
        <pre>Small correction to this part:

"This also applies to Should-Start and I think to NetworkManager-wait-online -
I think this will be triggered by anything considered to match
SPECIAL_NETWORK_ONLINE_TARGET in sysv-generator around line 515"

The bug really only affects the SysV "$network" service, I think, it does not
affect NetworkManager-wait-online. I was fooled by /etc/init.d/network on
Fedora, which has this stanza:

### BEGIN INIT INFO
# Provides: $network
# Should-Start: iptables ip6tables NetworkManager-wait-online NetworkManager
# Short-Description: Bring up/down networking
# Description: Bring up/down networking
### END INIT INFO

If the "Provides: $network" line is present, network.service will be in
/run/systemd/generator.late/network-online.target.wants/ . If I remove that
line, it is not.

I don't think that's correct either, but it's interestingly different. I
believe that case is hitting the code around the comment:

                                                /* NB: SysV targets
                                                 * which are provided
                                                 * by a service are
                                                 * pulled in by the
                                                 * services, as an
                                                 * indication that the
                                                 * generic service is
                                                 * now available. This
                                                 * is strictly
                                                 * one-way. The
                                                 * targets do NOT pull
                                                 * in the SysV
                                                 * services! */

So...yeah, mo' problems.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>