<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - nspawn: block devices passed to --bind/bind-ro are not accessible inside the container" href="https://bugs.freedesktop.org/show_bug.cgi?id=90385#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - nspawn: block devices passed to --bind/bind-ro are not accessible inside the container" href="https://bugs.freedesktop.org/show_bug.cgi?id=90385">bug 90385</a> from <a class="email" href="mailto:lennart@poettering.net" title="Lennart Poettering <lennart@poettering.net>"> Lennart Poettering</a> <pre>Comment on <a href="attachment.cgi?id=115749" name="attach_115749" title="patch adapted according to Lennart's implementation suggestions">attachment 115749</a> <a href="attachment.cgi?id=115749&action=edit" title="patch adapted according to Lennart's implementation suggestions">[details]</a> <a href='page.cgi?id=splinter.html&bug=90385&attachment=115749'>[review]</a> patch adapted according to Lennart's implementation suggestions A couple of fixes: pleas structly use 8ch space indenting, you appear to indent by 4ch sometimes. More importantly though, the code for nspawn changed in current git quite a bind, arg_bind and arg_bind_ro do not exist like this anymore. Please rebase on current git. Also, I think this should work the same way for character and block device nodes. i.e. just checking S_ISBLK() appears to be restrictive. We currently have two functions is_symlink() and is_dir() in util.[ch]. I think it would be best to introduce is_device_node() in this style, and move the stat() check into it, and then look for S_ISBLK() || S_ISCHR()...</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>