[systemd-commits] 4 commits - fixme Makefile.am src/dbus-manager.c src/job.c src/manager.c src/manager.h src/systemctl.c src/util.h units/tmpwatch.service units/tmpwatch.timer

[Gustavo Sverzut Barbieri]

On Tue, Sep 21, 2010 at 1:47 AM, Gustavo Sverzut Barbieri
<barbieri at profusion.mobi> wrote:
> On Mon, Sep 20, 2010 at 11:26 PM, Lennart Poettering
> <lennart at kemper.freedesktop.org> wrote:
>> commit f0a73e245c1646c6c62a3bd0a3db969dd2e55edc
>> Author: Lennart Poettering <lennart at poettering.net>
>> Date:   Tue Sep 21 03:38:32 2010 +0200
>>
>>    units: add default tmpwatch units
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 3ab79ba..b5b2a9d 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -979,12 +979,16 @@ install-data-hook:
>>                        dev-mqueue.automount \
>>                        proc-sys-fs-binfmt_misc.automount \
>>                        sys-kernel-debug.automount \
>> -                       sys-kernel-security.automount && \
>> +                       sys-kernel-security.automount \
>> +                       tmpwatch.timer \
>> +                       tmpwatch.service && \
>
> rather confusing why you link tmpwatch.service to sysinit.target.wants but
>
>> +[Install]
>> +WantedBy=shutdown.target
>
> suggests it to be installed at shutdown.target. IMO it should be
> always shutdown.target, with the TIMER being wanted by sysinit.target.
> That way we don't waste time during startup.

argh! and tmpwatch.* are not installed :-/ Will send a patch.


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbieri at gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202