[systemd-commits] TODO src/journal

Lennart Poettering lennart at kemper.freedesktop.org
Tue Jul 3 02:58:42 PDT 2012


 TODO                     |    2 ++
 src/journal/sd-journal.c |    7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit e590af2666d2a958d355f9957e77ec967bb16011
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Jul 3 11:58:16 2012 +0200

    journal: fix iteration through journal if one file is corrupt

diff --git a/TODO b/TODO
index 56798a5..b8369c3 100644
--- a/TODO
+++ b/TODO
@@ -22,6 +22,8 @@ Bugfixes:
 
 Features:
 
+* journald: _BOOT_ID triggers too many collisions.
+
 * journald: we currently rotate only after MaxUse+MaxFilesize has been reached.
 
 * reexec journald across initrd transition
diff --git a/src/journal/sd-journal.c b/src/journal/sd-journal.c
index 9c6cbaa..7588459 100644
--- a/src/journal/sd-journal.c
+++ b/src/journal/sd-journal.c
@@ -670,9 +670,10 @@ static int real_journal_next(sd_journal *j, direction_t direction) {
                 bool found;
 
                 r = next_beyond_location(j, f, direction, &o, &p);
-                if (r < 0)
-                        return r;
-                else if (r == 0)
+                if (r < 0) {
+                        log_debug("Can't iterate through %s, ignoring: %s", f->path, strerror(-r));
+                        continue;
+                } else if (r == 0)
                         continue;
 
                 if (!new_current)



More information about the systemd-commits mailing list