[systemd-commits] 3 commits - README src/bootchart src/journal

Zbigniew Jędrzejewski-Szmek zbyszek at kemper.freedesktop.org
Tue Dec 10 04:33:54 PST 2013


 README                        |    5 ++---
 src/bootchart/svg.c           |   10 +++++-----
 src/journal/journald-server.c |    3 +++
 3 files changed, 10 insertions(+), 8 deletions(-)

New commits:
commit 4987623d011c534a22a490b17a8e0ec81d1ac30c
Author: Dan McGee <dan at archlinux.org>
Date:   Sun Dec 8 11:27:06 2013 -0600

    Bring bootchart code in line with CODING_STYLE
    
    Use double and not float, as there is little to no benefit.

diff --git a/src/bootchart/svg.c b/src/bootchart/svg.c
index 3a015cc..97c8237 100644
--- a/src/bootchart/svg.c
+++ b/src/bootchart/svg.c
@@ -68,16 +68,16 @@ static double idletime = -1.0;
 static int pfiltered = 0;
 static int pcount = 0;
 static int kcount = 0;
-static float psize = 0;
-static float ksize = 0;
-static float esize = 0;
+static double psize = 0;
+static double ksize = 0;
+static double esize = 0;
 static struct list_sample_data *sampledata;
 static struct list_sample_data *prev_sampledata;
 extern struct list_sample_data *head;
 
 static void svg_header(void) {
-        float w;
-        float h;
+        double w;
+        double h;
         struct list_sample_data *sampledata_last;
 
         sampledata = head;

commit 2d43b190901902dbd98ccea77c1d1ddc9e2a9955
Author: Dan McGee <dan at archlinux.org>
Date:   Sun Dec 8 13:27:05 2013 -0600

    Ensure unit is journaled for short-lived or oneshot processes
    
    In the time it takes to process incoming log messages, the process we
    are logging details for may exit. This means the cgroup data is no
    longer available from '/proc'. Unfortunately, the way the code was
    structured before, we never log _SYSTEMD_UNIT if we don't have this
    cgroup information.
    
    Add an else if case that allows the passed in unit_id to be logged even
    if we couldn't capture cgroup information. This ensures a command like
    `journalctl -u run-XXX` will return all log messages from a oneshot
    process.

diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c
index 01e75b6..fc8115c 100644
--- a/src/journal/journald-server.c
+++ b/src/journal/journald-server.c
@@ -626,6 +626,9 @@ static void dispatch_message_real(
                         }
 
                         free(c);
+                } else if (unit_id) {
+                        x = strappenda("_SYSTEMD_UNIT=", unit_id);
+                        IOVEC_SET_STRING(iovec[n++], x);
                 }
 
 #ifdef HAVE_SELINUX

commit 06d461ee6f3da6650e6d023d7828455752d70b0b
Author: Shawn Landden <shawn at churchofgit.com>
Date:   Mon Dec 9 07:04:06 2013 -0800

    update README to not suggest that systemd works without procfs

diff --git a/README b/README
index cc43953..7cd1f1d 100644
--- a/README
+++ b/README
@@ -45,6 +45,7 @@ REQUIREMENTS:
           CONFIG_EPOLL
           CONFIG_NET
           CONFIG_SYSFS
+          CONFIG_PROC_FS
 
         Linux kernel >= 3.8 for Smack support
 
@@ -75,9 +76,7 @@ REQUIREMENTS:
           CONFIG_TMPFS_XATTR
           CONFIG_SECCOMP
 
-        For systemd-bootchart, a kernel with procfs support and
-        several proc output options enabled is required:
-          CONFIG_PROC_FS
+        For systemd-bootchart, several proc debug interfaces are required:
           CONFIG_SCHEDSTATS
           CONFIG_SCHED_DEBUG
 



More information about the systemd-commits mailing list