[systemd-commits] 3 commits - src/journal src/journal-remote src/login

[Zbigniew Jędrzejewski-Szmek]

 src/journal-remote/journal-gatewayd.c |    2 +-
 src/journal/journald-native.c         |    2 +-
 src/journal/journald-stream.c         |    2 +-
 src/journal/journald-syslog.c         |    2 +-
 src/login/pam_systemd.c               |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e51728b0475f68d0f84c1dca8a02c17c9f5a6a29
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Sun Apr 12 22:46:37 2015 -0400

    journal-gatewayd: use (void) to silence coverity
    
    CID #996297.

diff --git a/src/journal-remote/journal-gatewayd.c b/src/journal-remote/journal-gatewayd.c
index bba0d12..07aebd8 100644
--- a/src/journal-remote/journal-gatewayd.c
+++ b/src/journal-remote/journal-gatewayd.c
@@ -781,7 +781,7 @@ static int request_handler_machine(
                 return mhd_respondf(connection, MHD_HTTP_INTERNAL_SERVER_ERROR, "Failed to determine disk usage: %s\n", strerror(-r));
 
         if (parse_env_file("/etc/os-release", NEWLINE, "PRETTY_NAME", &os_name, NULL) == -ENOENT)
-                parse_env_file("/usr/lib/os-release", NEWLINE, "PRETTY_NAME", &os_name, NULL);
+                (void) parse_env_file("/usr/lib/os-release", NEWLINE, "PRETTY_NAME", &os_name, NULL);
 
         get_virtualization(&v);
 

commit 4a61c3e51e96a747c30598d78ee3a24e7c569e9f
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Sun Apr 12 22:43:08 2015 -0400

    journal: use (void) to silence coverity
    
    This shouldn't really fail and anyway not much we can do about it.
    
    CID #996292, #996294, #996295.

diff --git a/src/journal/journald-native.c b/src/journal/journald-native.c
index 851625d..da3faef 100644
--- a/src/journal/journald-native.c
+++ b/src/journal/journald-native.c
@@ -433,7 +433,7 @@ int server_open_native_socket(Server*s) {
                 if (r < 0)
                         return log_error_errno(errno, "bind(%s) failed: %m", sa.un.sun_path);
 
-                chmod(sa.un.sun_path, 0666);
+                (void) chmod(sa.un.sun_path, 0666);
         } else
                 fd_nonblock(s->native_fd, 1);
 
diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c
index bc5b26d..b572147 100644
--- a/src/journal/journald-stream.c
+++ b/src/journal/journald-stream.c
@@ -720,7 +720,7 @@ int server_open_stdout_socket(Server *s, FDSet *fds) {
                 if (r < 0)
                         return log_error_errno(errno, "bind(%s) failed: %m", sa.un.sun_path);
 
-                chmod(sa.un.sun_path, 0666);
+                (void) chmod(sa.un.sun_path, 0666);
 
                 if (listen(s->stdout_fd, SOMAXCONN) < 0)
                         return log_error_errno(errno, "listen(%s) failed: %m", sa.un.sun_path);
diff --git a/src/journal/journald-syslog.c b/src/journal/journald-syslog.c
index 26fdf62..90b7530 100644
--- a/src/journal/journald-syslog.c
+++ b/src/journal/journald-syslog.c
@@ -398,7 +398,7 @@ int server_open_syslog_socket(Server *s) {
                 if (r < 0)
                         return log_error_errno(errno, "bind(%s) failed: %m", sa.un.sun_path);
 
-                chmod(sa.un.sun_path, 0666);
+                (void) chmod(sa.un.sun_path, 0666);
         } else
                 fd_nonblock(s->syslog_fd, 1);
 

commit 2ae4842b6c8b7c3445bceaa8bfc8d019a7d9edcd
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Sun Apr 12 22:41:20 2015 -0400

    pam_system: use (void) to silence coverity
    
    CID #996284.

diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c
index cdd45ac..1416701 100644
--- a/src/login/pam_systemd.c
+++ b/src/login/pam_systemd.c
@@ -336,7 +336,7 @@ _public_ PAM_EXTERN int pam_sm_open_session(
 
         /* If this fails vtnr will be 0, that's intended */
         if (!isempty(cvtnr))
-                safe_atou32(cvtnr, &vtnr);
+                (void) safe_atou32(cvtnr, &vtnr);
 
         if (!isempty(display) && !vtnr) {
                 if (isempty(seat))