[systemd-commits] 2 commits - TODO src/core src/shared

[Lennart Poettering]

 TODO             |   15 +++++++++++++++
 src/core/main.c  |    2 --
 src/shared/log.c |    4 +++-
 3 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit 5e07a79e84ab8b045b9df1a2719f14fc84471a1d
Author: Lennart Poettering <lennart at poettering.net>
Date:   Wed Feb 4 01:42:49 2015 +0100

    core: don't reset log level to NOTICE if we get quiet on the kernel cmdline
    
    quiet should really just have an effect on the stuff we dump on the
    console, not what we log elsewhere.
    
    Hence:
    
            debug on kernel cmdline → interpreted by every tool, turns up
            log levels to "debug" everywhere.
    
            quiet on kernel cmdline → interpreted only by PID 1 (and
            obviously the kernel) no alteration of the max log level, but
            turns off status output.
    
    http://lists.freedesktop.org/archives/systemd-devel/2014-December/026271.html

diff --git a/src/core/main.c b/src/core/main.c
index 0480bc8..0749f04 100644
--- a/src/core/main.c
+++ b/src/core/main.c
@@ -367,8 +367,6 @@ static int parse_proc_cmdline_item(const char *key, const char *value) {
 
         } else if (streq(key, "quiet") && !value) {
 
-                log_set_max_level(LOG_NOTICE);
-
                 if (arg_show_status == _SHOW_STATUS_UNSET)
                         arg_show_status = SHOW_STATUS_AUTO;
 
diff --git a/src/shared/log.c b/src/shared/log.c
index 9c01560..03ef018 100644
--- a/src/shared/log.c
+++ b/src/shared/log.c
@@ -914,7 +914,9 @@ static int parse_proc_cmdline_item(const char *key, const char *value) {
          * The systemd.log_xyz= settings are parsed by all tools, and
          * so is "debug".
          *
-         * However, "quiet" is only parsed by PID 1!
+         * However, "quiet" is only parsed by PID 1, and only turns of
+         * status output to /dev/console, but does not alter the log
+         * level.
          */
 
         if (streq(key, "debug") && !value)

commit b9be39bfb4ed8e43a7c445831131e44be998eb32
Author: Lennart Poettering <lennart at poettering.net>
Date:   Wed Feb 4 01:42:46 2015 +0100

    update TODO

diff --git a/TODO b/TODO
index 415efee..95005aa 100644
--- a/TODO
+++ b/TODO
@@ -34,6 +34,21 @@ External:
 
 Features:
 
+* When runlevel3.target is used to define dependencies on other units,
+  then we don't pick it up currently, since nothing ever references
+  runlevel3.target, and never figure out it actually is just an alias
+  for multi-user.target. A hackish fix could be to add a .wants link
+  from multi-user.target to runlevel3.target, if it is a symlink to
+  it. Best would be to create this .wants/ symlink from
+  sysv-generator. systemd would then load the referenced unit, figure
+  out it is just an alias and that the dependency would be on itself
+  and suppress it. Thus the alias and its deps would be loaded as
+  desired.
+
+* PID 1: when invoking systemctl preset-all on first boots, operate in
+  an exclusively additive way, i.e. never remove any pre-existing
+  symlinks, only add new ones.
+
 * Introduce $LISTEN_NAMES to complement $LISTEN_FDS, containing a
   colon separated list of identifiers for the fds passed.