[systemd-commits] src/shared

Zbigniew Jędrzejewski-Szmek zbyszek at kemper.freedesktop.org
Thu Feb 5 16:44:46 PST 2015


 src/shared/log.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit ee46e555702715f1adcc3381dac73e76e2d9a048
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Thu Feb 5 19:44:13 2015 -0500

    shared/log: read /proc/cmdline only in daemons
    
    http://lists.freedesktop.org/archives/systemd-devel/2015-February/027960.html

diff --git a/src/shared/log.c b/src/shared/log.c
index 03ef018..646a1d6 100644
--- a/src/shared/log.c
+++ b/src/shared/log.c
@@ -949,7 +949,11 @@ static int parse_proc_cmdline_item(const char *key, const char *value) {
 void log_parse_environment(void) {
         const char *e;
 
-        (void) parse_proc_cmdline(parse_proc_cmdline_item);
+        if (get_ctty_devnr(0, NULL) < 0)
+                /* Only try to read the command line in daemons.
+                   We assume that anything that has a controlling
+                   tty is user stuff. */
+                (void) parse_proc_cmdline(parse_proc_cmdline_item);
 
         e = secure_getenv("SYSTEMD_LOG_TARGET");
         if (e && log_set_target_from_string(e) < 0)



More information about the systemd-commits mailing list