[systemd-devel] [PATCH] unit-name: fix unit name escaping

Mike Kelly pioto at pioto.org
Fri Oct 1 16:58:07 PDT 2010


we want to do a bitwise shift, not a greater-than comparision
---
 src/unit-name.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/unit-name.c b/src/unit-name.c
index 2e2948a..868d13e 100644
--- a/src/unit-name.c
+++ b/src/unit-name.c
@@ -211,7 +211,7 @@ static char* do_escape(const char *f, char *t) {
                 else if (*f == '-' || *f == '\\' || !strchr(VALID_CHARS, *f)) {
                         *(t++) = '\\';
                         *(t++) = 'x';
-                        *(t++) = hexchar(*f > 4);
+                        *(t++) = hexchar(*f >> 4);
                         *(t++) = hexchar(*f);
                 } else
                         *(t++) = *f;
-- 
1.7.2.3



More information about the systemd-devel mailing list