[systemd-devel] [PATCH] gentoo: locale-setup support.

[Gustavo Sverzut Barbieri]

On Mon, Sep 20, 2010 at 5:58 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Sun, 19.09.10 21:32, Gustavo Sverzut Barbieri (barbieri at profusion.mobi) wrote:
>
> Heya,
>
>> Use locale variables from /etc/profile.env as Gentoo's openrc
>> runscript does (tool that is used by /etc/init.d/* services).
>
> Hmpf. I am still a bit torn about this. We are not a shell, and
> interpreting those "export" lines looks like a call for desaster,
> because we don't actually really understand shell syntax here. For
> example, if somebody says "export LC_NUMERIC=$LC_TIME", then we'll choke
> on this.

this will never happen on that file. As I said, this file is a
"compiled" version generated by env-update... it pre-resolves, check
for errors and all. for all purposes it is a static file and not a
shell one.


> I am not convinced that it is smart to claim we supported something
> which we really don't.
>
> I'd recommend to just officially acknoweledge that systemd and openrc
> deviate here, and document it. In most cases the difference should be
> invisible anyway, since the user shell eventually pulls in these
> settings for all user apps.

well, when you said that to me originally I agreed, but I double
checked their code and they do export such functions, and the services
we start will not rely on a shell that inherited such values, so we
have to do them :-/


> In the long run I'd like to get rid of all these little differences
> between the distros anyway (i.e. all those little #ifdef TARGET_FEDORA
> and #ifdef TARGET_GENTOO), so maybe one should see this as a chance to
> say that Gentoo here is already one step further than the other distros?

well, I'd keep it there for now, but sure we can start to document all
the expected files and variables somewhere, then we can just say "if
you're using systemd use X for A, Y for B... " and then drop all the
#ifdef.

the "one step further" is the worst excuse I ever saw... I like it
nonetheless :-)


> Sorry if this is disappointing!

yeah, so what? drop it if you wish, I don't use those settings myself
:-) was doing it just for "completeness"!

BR,
-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbieri at gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202