[systemd-devel] [PATCH] fix strange addition idiom

Lennart Poettering lennart at poettering.net
Thu Apr 14 08:26:08 PDT 2011


On Wed, 13.04.11 20:21, Kurt H Maier (karmaflux at gmail.com) wrote:

> 
> index bd55e65..ce902ef 100644
> --- a/src/reply-password.c
> +++ b/src/reply-password.c
> @@ -82,6 +82,7 @@ int main(int argc, char *argv[]) {
>                  }
> 
>                  truncate_nl(packet+1);
> +               /* prefix + packet string + NUL in this order */
>                  length = 1 + strlen(packet+1) + 1;
>          } else if (streq(argv[1], "0")) {
>                  packet[0] = '-';

Nah, no additional comment necessary. The line is documenting itself,
that's why I put it like this.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list