[systemd-devel] [PATCH] Add --disable-binfmt configure switch

[Lennart Poettering]

On Mon, 25.04.11 22:25, Miklos Vajna (vmiklos at frugalware.org) wrote:

> On Wed, Apr 20, 2011 at 11:02:39PM +0200, Miklos Vajna <vmiklos at frugalware.org> wrote:
> > I'm attaching a patch adding --disable-binfmt.
> 
> Updated version, taking care of .automount/.mount units as well.

OK, one last request before I merge it. Could you rename the conditional
to ENABLE_BINFMT please? I'd like to make clear that this is a boolean
conditional instead of anything elsse.

> +if BINFMT
> +rootlibexec_PROGRAMS += systemd-binfmt
> +endif

Oh, and please add a line break after the +=. We have linebreaks on all
other automake targets heere.

> +if BINFMT
> +nodist_systemunit_DATA += units/systemd-binfmt.service
> +endif

here too.
>  
> +if BINFMT
> +EXTRA_DIST += units/systemd-binfmt.service.in
> +endif

and here.

> +if BINFMT
> +MANPAGES += man/binfmt.d.5
> +endif

and please here too.

Otherwise is fine. In fact this is exemplary how I'd like to see all
other conditional compilation hooks for stuff that isn't necessary for
embedded implemented.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.