[systemd-devel] [PATCH] cryptsetup: fix keyfile size option processing
lennart at poettering.net
Tue Apr 26 12:50:48 PDT 2011
On Tue, 26.04.11 00:15, Milan Broz (mbroz at redhat.com) wrote:
> /etc/crypttab uses "size" argument only for plain crypt mapping
> (and input is limited to volume key size)
> For LUKS it always read whole keyfile (no arguments except "luks"
> should be in crypttab).
> Because of bug in cryptsetup 1.2.0 (fixed in 1.3.0) library
> did not enforced keyfile size argument, so this bug was
> hidden for some time.
> Patch also converts size in bits to bytes like excepted
> by libcryptsetup api.
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=36264
Looks good to me.
Milan, thanks for tracking this down and preparing a patch! Much
Lennart Poettering - Red Hat, Inc.
More information about the systemd-devel