[systemd-devel] Environment & EnvironmentFile in unit files

[Lennart Poettering]

On Thu, 27.01.11 11:31, Gustavo Sverzut Barbieri (barbieri at profusion.mobi) wrote:

> > However, I had my difficulties, and one of them is with environment
> > variables in unit files. Are they really solely meant to be used for the
> > started processes, and in no other unit file directives? I'd like to
> > give some examples, where I could have used them in order to reduce
> > redundancy in the unit files code and also give the user configuration
> > opportunities via "EnvironmentFile=" for more than the command line for
> > launching the process itself, without having him to modify the unit
> > file. You might point out conceptual errors I'm doing, but hopefully I
> > can clarify what my problem is, maybe you'll consider this as a feature?
> 
> I'll let  the final decision to Lennart and Kay, the maintainers, but
> from what I see and agree the idea is to avoid such crap completely.
> 
> 1. these ExecPreStart are completely non-sense. These should be in
> lircd if it really needs it. Send them the patches to fix it.
> Meanwhile just make this a single binary that does such work, but
> consider it a temporary remedy.
> 
> 2. these non-daemon configuration files should be removed. It causes
> no good other than stupid fragmentation among distributions (some in
> /etc/conf.d, others in /etc/sysconfig, ...). The way to go is the
> daemon itself to have its configuration file and read it directly.
> 
> 3. do not use forking. I consider it a temporary solution, but the way
> to go is to make the daemons do not fork and let systemd babysit them.
> If lircd does not support something like that, send them the patches.
> 
> 4. last but not least these things that rely on /dev should be
> activated by udev whenever it notifies the device is presence.

I agree with Gustavo's points.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.