[systemd-devel] [PATCH] Add the most common consoles that MeeGo needs

[Paul Menzel]

Dear Chris,


please just post plain text messages (and no HTML) to lists [1].

Am Freitag, den 01.07.2011, 09:19 -0700 schrieb Chris Ferron:
> MeeGo will use several consoles depending on the hardware adaptations.
> This patch adds the most common to the serial-getty unit Install section 
> so when systemd is built for MeeGo as its distribution, you get the most 
> common Aliased for installation by the user.

Why don’t you use that as a commit message?

>  From c50559ea74069061401c8a218d73d515d7b9cd09 Mon Sep 17 00:00:00 2001
> From: Chris Ferron <chris.e.ferron at linux.intel.com>
> Date: Fri, 1 Jul 2011 08:54:37 -0700
> Subject: [PATCH] Add the most common consoles that MeeGo as a distribution
>   will need.

Please turn of line breaks when pasting stuff. You can also use `git
send-email` to send patches.

> ---
>   units/serial-getty at .service.m4 |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/units/serial-getty at .service.m4 b/units/serial-getty at .service.m4
> index 082290c..aea47be 100644
> --- a/units/serial-getty at .service.m4
> +++ b/units/serial-getty at .service.m4
> @@ -9,6 +9,9 @@
>   Description=Serial Getty on %I
>   BindTo=dev-%i.device
>   After=dev-%i.device systemd-user-sessions.service 
> plymouth-quit-wait.service
> +m4_ifdef(`TARGET_MEEGO',
> +After=dev-%i.device systemd-user-sessions.service
> +)m4_dnl
>   m4_ifdef(`TARGET_FEDORA',
>   After=rc-local.service
>   )m4_dnl
> @@ -44,3 +47,9 @@ KillMode=process
>   # Some login implementations ignore SIGTERM, so we send SIGHUP
>   # instead, to ensure that login terminates cleanly.
>   KillSignal=SIGHUP
> +
> +m4_ifdef(`TARGET_MEEGO',
> +[Install]
> +Alias=sysinit.target.wants/serial-getty at ttyS0.service 
> sysinit.target.wants/serial-getty at ttyS1.service 
> sysinit.target.wants/serial-getty at tty01.service 
> sysinit.target.wants/serial-getty at ttyO2.service
> +)m4_dnl
> +

Unnecessary line at the end?

Are such customization wanted upstream or are there other ways to
implement that? I would imagine this becomes very complex if every
distribution starts adding such things.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20110701/acecddfd/attachment.pgp>