[systemd-devel] v19: plymouth-quit-wait waits forever/no getty

[Andrey Borzenkov]

On Wed, Mar 2, 2011 at 12:44 AM, Lennart Poettering
<lennart at poettering.net> wrote:
>>  src/service.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/service.c b/src/service.c
>> index 39a46d6..297f97b 100644
>> --- a/src/service.c
>> +++ b/src/service.c
>> @@ -2014,7 +2014,7 @@ static void service_enter_start(Service *s) {
>>
>>          if ((r = service_spawn(s,
>>                                 c,
>> -                               s->type == SERVICE_FORKING || s->type == SERVICE_DBUS || s->type == SERVICE_NOTIFY,
>> +                               s->type == SERVICE_FORKING || s->type == SERVICE_DBUS || s->type == SERVICE_NOTIFY || s->type == SERVICE_ONESHOT,
>>                                 true,
>>                                 true,
>>                                 true,
>
> Ah, good catch.
>
> Hmm, this patch needs to be more complicated unfortunately: we don't
> want timeouts on oneshot services by default (to not fuck with stuff
> like fsck for example). Hence we should honour timeouts in all cases,
> but choose different default timeout values depending on the type.
>

OK, but it is independent of correct timeout handling, is not it?
Right now e.g. all fsck units have Timeout=0, which means nothing
changes for them.