[systemd-devel] [Patch v2] Fix systemd-readahead-collect on mips platform

fykcee1 at gmail.com fykcee1 at gmail.com
Wed Mar 16 19:26:05 PDT 2011


Hi Lennart,

This is the second version of patch "Fix systemd-readahead-collect on
mips platform".

2011/3/17 Lennart Poettering <lennart at poettering.net>:
>> The patch fix two problems:
>> 1. The system call number of __NR_fanotify_* is not corrrect on mips.
>
> This one definitely makes sense for us to merge. Could you split this
> one off and prep a whitespace clean patch for it? (We actually have a
> git hook that ensures that patches are whitespace clean. It is enabled
> when you run autogen.sh. When I tried to merge your earlier patch today
> I couldn't do so, since your patch was not whitespace clean.)
>
> I you prep me a patch for this part I'll merge it right-away.
>
> BTW, no need to include config.h from the C sources. We do so
> automatically for all sources via gcc's -include switch on the command
> line.
Changes since v1:
1. Split "system call number fix" off.
2. Trailing Whitespace clean up.
3. Don't include config.h in missing.h (it will be done automatically)



-- 
Regards,
- cee1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-broken-systemd-readahead-collect-on-mips.patch
Type: application/octet-stream
Size: 2718 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20110317/6144dba6/attachment-0001.obj>


More information about the systemd-devel mailing list