[systemd-devel] Dependency loop due to network filesystem and quotacheck; suboptimal loop resolution.

[Tomasz Torcz]

On Thu, Mar 17, 2011 at 03:44:46PM +0100, Lennart Poettering wrote:
> On Thu, 17.03.11 16:50, Andrey Borzenkov (arvidjaar at gmail.com) wrote:
> 
> > 
> > On Thu, Mar 17, 2011 at 4:43 AM, Lennart Poettering
> > <lennart at poettering.net> wrote:
> > > On Thu, 10.03.11 00:42, Andrey Borzenkov (arvidjaar at gmail.com) wrote:
> > >> It is not. Suggested patch attached.
> > >
> > >> From: Andrey Borzenkov <arvidjaar at gmail.com>
> > >> Subject: [PATCH] mount: do not add dependency on network filesystem to quotacheck
> > >>
> > >> This creates loop:
> > >>
> > >> fs -> quotacheck -> basic -> network -> fs
> > >>
> > >> It does not look like quota was enabled for them in /etc/init.d/netfs
> > >> anyway.  If quota is required, it probably should be implemented as
> > >> per mount point unit.
> > >
> > [...]
> > > Anywaym uf you rework this patch to check for the usrquota/grpquota
> > > options I'd merge it promptly
> > 
> > But it does not solve the problem of usrquota being set on a _netfs
> > filesystem. So either this has to be skipped completely or additional
> > unit provided.
> 
> Well, isn't it kind of a misconfiguration if people use
> "usrquota,grpquota" on a network filesystem? But I guess an explicit
> check for _netdev and fstype_is_network(p->fstype) can't hurt.


  As for "_netdev", it is quite possible for quota-supporting filesystem (like ext*)
to be mounted from network device (iSCSI, AoE or other).
  "_netfs" seem not to be documented in mount manpage.

-- 
Tomasz Torcz            There exists no separation between gods and men:
xmpp: zdzichubg at chrome.pl   one blends softly casual into the other.