[systemd-devel] PATCH: fix warning on ppc

Lennart Poettering lennart at poettering.net
Mon Mar 26 15:22:08 PDT 2012


On Thu, 22.03.12 09:45, Frederic Crozat (fcrozat at suse.com) wrote:

> Hi,
> 
> while building systemd on ppc, I spotted a warning in src/journal/cat.c
> where a char could be used to retrieve a error code, except on ppc, char
> are unsigned. After discussing the issue with Kay on irc, it was decided
> to use int8_t instead.
> 
> Attached patch for this fix.
> +static int8_t arg_priority = LOG_INFO;

This is otherwise always an int, so we should use a proper int here,
too (and not int8_t or so)

Thanks for finding this, fixed now in git.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list