[systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

[Lennart Poettering]

On Wed, 17.04.13 19:25, Henrik Grindal Bakken (hgb at ifi.uio.no) wrote:

> 
> Lennart Poettering <lennart at poettering.net> writes:
> 
> > On Wed, 17.04.13 18:48, Henrik Grindal Bakken (hgb at ifi.uio.no) wrote:
> >
> >> @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA =
> >>  check_PROGRAMS =
> >>  check_DATA =
> >>  noinst_tests=
> >> +if ENABLE_TESTS
> >>  noinst_PROGRAMS = $(noinst_tests)
> >>  TESTS = $(noinst_tests)
> >> +else
> >> +noinst_PROGRAMS =
> >> +TESTS =
> >> +endif
> >>  udevlibexec_PROGRAMS =
> >
> > There must be two different vars for these, you cannot collapse them
> > (see other mail for explanation).
> 
> Yeah, so then my first patch is back to the number one candidate.  Or I
> can make a new one, similar to this, with two variable.  Perhaps that's
> prettier?

Hmm, why do you bother with the tests only appearing on noinst_PROGRAMS=
anyway? Those are never run automatically, so they shouldn't matter to
you? 

To me it sounds that all that should be done assing the empty string to
TESTS when tests are supposed to be turned off.

Of course, there are currently two places where TESTS= is directly
modified, but that should be easily fixed..

Lennart

-- 
Lennart Poettering - Red Hat, Inc.