[systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

[Darren Hart]

On Thu, 2013-08-22 at 00:32 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Aug 21, 2013 at 11:13:41AM -0700, Darren Hart wrote:
> > Enable cross-compiling by allowing the user to specify an alternative to
> > the /usr/include directory for the EFI includes. Add a variable INCDIR
> > defaulting to /usr/include, but still allowing the user to provide their
> > own value.
> > 
> > Signed-off-by: Darren Hart <dvhart at linux.intel.com>
> > ---
> >  Makefile.am | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index c3dfcb2..5dc9493 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -72,10 +72,11 @@ CLEANFILES += man/gummiboot.8
> >  efi_loadername = gummiboot$(MACHINE_TYPE_NAME).efi
> >  efi_sources = src/efi/gummiboot.c
> >  
> > +INCDIR := /usr/include
> Please not like this. There's no reason to use :=, and

Why not? In a cross compilation environment, this may need to be
overridden...

> this should be an AC_ARG_VAR defined in configure.ac, so that
> it is properly advertised and remembered.
> 
> Zbyszek

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel