[systemd-devel] [PATCH] fstab-generator: introduce rd.weak_sysroot to bypass failures in sysroot.mount

[Zbigniew Jędrzejewski-Szmek]

On Wed, Jul 31, 2013 at 12:46:22AM +0800, WANG Chao wrote:
> On 07/31/13 at 12:32am, WANG Chao wrote:
> > On 07/30/13 at 03:46pm, Zbigniew Jędrzejewski-Szmek wrote:
> > > On Tue, Jul 30, 2013 at 09:43:16AM -0400, Vivek Goyal wrote:
> > > > [CC harald]
> > > > 
> > > > Not sure if this is right way to do or not but I will give more
> > > > background about the issue.
> > > > 
> > > > This assumption seems to be built into initramfs and systemd that root
> > > > should always be mountable. If one can't mount root, it is a fatal
> > > > failure.
> > > > 
> > > > But in case of kdump initramfs, this assumption is no more valid. Core
> > > > might be being saved to a target which is not root (say over ssh). And
> > > > even if mounting root fails, it is ok.
> > > > 
> > > > So we kind of need a mode (possibly driven by command line option) where
> > > > if mouting root failed, it is ok and continue with mouting other targets
> > > > and kdump module will then handle errors.
> > > Maybe rootfsflags=nofail could do be used as this flag?
> > 
> > rootflags=nofail works. Thanks.
> > 
> > Although it results in a little difference between my approach, I prefer
> > use this one than adding another cmdline param.
> 
> I just find nofail option only works when mnt device doesn't exists.
I think we treat nofail slightly differently, and don't make the
.mount unit a requirement for local-fs.target or initrd-fs.target.

Zbyszek

> What if the filesytem is corrupted? sysroot.mount will and
> initrd-root-fs.target will never reach.
-- 
they are not broken. they are refucktored
                           -- alxchk