[systemd-devel] [PATCH 3/3] logind: session: Fix not allowing more than one controller

[Lennart Poettering]

On Fri, 08.08.14 20:45, Olivier Brunel (jjk at jjacky.com) wrote:

> While a session can only ever have one controller, there can be more than
> one session with a controller at a time. However, because of the handling
> of SIGUSR1 for handling VT switch, trying to set a controller on a session
> while another session had a controller would fail.

I really don't feel comfortable with using SIGUSR1 for this, anyway I
must say... SIGUSR1 and SIGUSR2 I think should be left for admins to
communicate with the daemon for some simple operations, but using this
internally sounds wrong. Now, the VT is so stupid to require a signa
handler here, but I think using SIGRTMIN+1 or so might be the better
choice here?

Now, what makes we wonder here, shouldn't we just install a single
signal event handler for this when logind initializes, and leaving it on
until the very end?

David, could you comment on this, please?

Lennart

-- 
Lennart Poettering, Red Hat