[systemd-devel] [PATCH] bus: fix match_parse for unquoted matches

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Sun Feb 16 08:26:29 PST 2014


On Sun, Feb 16, 2014 at 02:59:27AM +0100, Peeters Simon wrote:
> 2014-02-16 3:01 GMT+01:00 Simon Peeters <peeters.simon at gmail.com>:
> > ---
> >  src/libsystemd/sd-bus/bus-match.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libsystemd/sd-bus/bus-match.c b/src/libsystemd/sd-bus/bus-match.c
> > index ffc9756..8280488 100644
> > --- a/src/libsystemd/sd-bus/bus-match.c
> > +++ b/src/libsystemd/sd-bus/bus-match.c
> > @@ -814,7 +814,7 @@ int bus_match_parse(
> >
> >                  value = NULL;
> >
> > -                if (q[1] == 0)
> > +                if (q[quoted] == 0)
> >                          break;
> >
> >                  if (q[quoted] != ',') {
> > --
> > 1.8.5.4
> >
> 
> this was why connman wasn't working on top of kdbus (the match parsing
> in bus-driverd would fail)

Applied.

It would be great to have a unit test for that...

Zbyszek


More information about the systemd-devel mailing list