[systemd-devel] [PATCH] build: put missing KMOD_CFLAGS into Makefile

Lennart Poettering lennart at poettering.net
Wed May 21 23:14:43 PDT 2014


On Thu, 22.05.14 02:46, Jan Engelhardt (jengelh at inai.de) wrote:

> 
> On Thursday 2014-05-22 02:27, Lennart Poettering wrote:
> >On Tue, 20.05.14 23:31, Jan Engelhardt (jengelh at inai.de) wrote:
> >
> >> The build fails if kmod is not in a default location.
> >
> >Thanks!
> >Applied!
> 
> Have you thought about just putting everything into AM_CFLAGS=,
> so that you do not need per-target flags?

Well, so far we kinda tried to keep _LDADD= in sync with _CFLAGS= for each
target, which sounds like a worthy goal, in particular because we
coudlnt really simplify the CFLAGS in a similar way. Also, given that
CLFAGS might include other flags thatn just -I we should be careful when
applying things to broadly...

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list