[systemd-devel] [PATCH] systemctl: add edit verb

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Fri Nov 28 14:41:19 PST 2014


On Fri, Nov 28, 2014 at 09:48:55PM +0100, Ronny Chevalier wrote:
> 2014-10-29 16:22 GMT+01:00 Ronny Chevalier <chevalier.ronny at gmail.com>:
> > It helps editing units by either creating a drop-in file, like
> > /etc/systemd/system/my.service.d/override.conf, or by copying the
> > original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full
> > option is specified.
> >
> > It invokes an editor on temporary files related to the unit files and
> > if the editor exited successfully, then it renames the temporary files
> > to their original names (e.g. my.service or override.conf) and
> > daemon-reload is invoked.
> >
> > If the temporary file is empty the modification is canceled.
> >
> > See https://bugzilla.redhat.com/show_bug.cgi?id=906824
> > ---
> 
> Is it ok if I apply this patch, or is there other remarks ? (Minus the
> recent log_error_errno changes)
Yes please go ahead! Your patch was one of the big things on my TODO list,
it's great that you that your account is finally created and you can push
it yourself.

I replied to the last version of the patch with some comments.

Zbyszek


More information about the systemd-devel mailing list