[systemd-devel] [PATCH 3/3] util : Remove dead code

Philippe De Swert philippedeswert at gmail.com
Tue Sep 16 14:39:38 PDT 2014


Hi Thomas,

On 17/09/14 00:36, Thomas H.P. Andersen wrote:
>> We only break out of the pre-ceding loop into the rest of the code
>> if fd is actually >= 0. So the < 0 check will never be true and
>> not necessary.
>>
>> Found with Coverity. Fixes: CID#1237577
> 
> I pushed a fix for this one 20 minutes ago. (I also set the CID as
> assigned to me but maybe we need a better way to coordinate?)

Oh yes you did. Missed it. Late night hacking ;) My mistake I should
have looked at the side box. I think setting it assigned was the right
way.

Cheers,

Philippe


More information about the systemd-devel mailing list