[systemd-devel] [PATCH 2/2] logind: add support for gpio-keys Power Button

David Herrmann dh.herrmann at gmail.com
Sun Sep 28 03:23:36 PDT 2014


Hi

On Sun, Sep 28, 2014 at 1:32 AM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> Hi,
>
> I'll merge 1/2 for now. As for 2/2, let's see what others say.

I'm against putting workarounds into udev just because kernel
maintainers refuse to give any feedback on evdev patches. With proper
evdev event masks, we can just open _any_ evdev device that has
KEY_POWER (and friends) enabled, but get woken up only for events
we're interested in. It would make all these whitelists obsolete.

Initial reaction of Dmitry (in April) was "That is something I had in
mind for a long time, great job!". Since then, I haven't heard a word
about the 4 further resends.. But at least I assume that the
event-masks are a reasonable feature, so I see little reason in
putting workarounds into udev. I just somehow need to figure out how
to get this upstream..

Sorry!
David


More information about the systemd-devel mailing list