[systemd-devel] [systemd-commits] 2 commits - src/libsystemd

[Tom Gundersen]

On Sun, Apr 5, 2015 at 11:50 AM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Fri, 03.04.15 13:23, Tom Gundersen (tomegun at kemper.freedesktop.org) wrote:
>
>>
>> -                tags = strdupa(value);
>> +                FOREACH_WORD_SEPARATOR(word, l, value, ":", state) {
>> +                        char *tag;
>>
>> -                while ((next = strchr(tags, ':'))) {
>> -                        next[0] = '\0';
>> +                        tag = strndupa(word, l);
>>
>
> Repeat after me: I shall not use alloca() within loops. I shall not
> use alloca() within loops. I shall not use alloca() within loops.
>
> This cannot work.

Fixed. Thanks!

Tom