[systemd-devel] [PATCH] bootchart: fix check for no fd

Daniel Mack daniel at zonque.org
Sun Apr 5 12:20:45 PDT 2015


On 04/05/2015 07:03 PM, Shawn Landden wrote:
> found with coverty report

Applied, thanks!

> ---
>  src/bootchart/store.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bootchart/store.c b/src/bootchart/store.c
> index f19427e..f159cba 100644
> --- a/src/bootchart/store.c
> +++ b/src/bootchart/store.c
> @@ -476,7 +476,7 @@ catch_rename:
>  
>                          /* re-fetch name */
>                          /* get name, start time */
> -                        if (!ps->sched) {
> +                        if (ps->sched < 0) {
>                                  sprintf(filename, "%d/sched", pid);
>                                  ps->sched = openat(procfd, filename, O_RDONLY|O_CLOEXEC);
>                                  if (ps->sched < 0)
> 



More information about the systemd-devel mailing list