[systemd-devel] [PATCH 5/5] build: use $(OBJCOPY)

[Kay Sievers]

On Wed, Apr 8, 2015 at 7:36 PM, Marc-Antoine Perennou
<Marc-Antoine at perennou.com> wrote:
> On 8 April 2015 at 19:03, Kay Sievers <kay at vrfy.org> wrote:
>> On Tue, Apr 7, 2015 at 8:54 PM, Marc-Antoine Perennou
>> <Marc-Antoine at perennou.com> wrote:
>>> ---
>>>  Makefile.am | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index 9b769ee..397a71c 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -2596,7 +2596,7 @@ $(systemd_boot_solib): $(systemd_boot_objects)
>>>         nm -D -u $@ | grep ' U ' && exit 1 || :
>>>
>>>  $(systemd_boot): $(systemd_boot_solib)
>>> -       $(AM_V_GEN) objcopy -j .text -j .sdata -j .data -j .dynamic \
>>> +       $(AM_V_GEN)$(OBJCOPY) -j .text -j .sdata -j .data -j .dynamic \
>>
>> This does not build here. I don't see who would define OBJCOPY.
>>
>> Kay
>
> Someone with a full CHOST-prefixed compilation toolchain would.
> I agree there should be a default value here, though, will send another
> fixed patch for this.

Please just test such stuff for the common setup before sending it
out, which is NOT cross-compilation. :)

Kay