[systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

Lennart Poettering lennart at poettering.net
Fri Apr 24 06:53:07 PDT 2015


On Fri, 24.04.15 15:52, Lennart Poettering (lennart at poettering.net) wrote:

> On Wed, 25.02.15 21:40, Ivan Shapovalov (intelfx100 at gmail.com) wrote:
> 
> Ivan,
> 
> > Because the order of coldplugging is not defined, we can reference a
> > not-yet-coldplugged unit and read its state while it has not yet been
> > set to a meaningful value.
> > 
> > This way, already active units may get started again.
> 
> > We fix this by deferring such actions until all units have been at least
> > somehow coldplugged.
> > 
> > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=88401
> 
> Hmm, so firstly, in this case, do those two alsa services 
> have RemainAfterExit=yes set? I mean, if they have not, they really
> should. I they have, then queuing jobs for them a second time is not
> really an issue, because the services are already running they will be
> eaten up eventually.

Oh, is there a simple reproducer for the issue btw?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list