[systemd-devel] [PATCH] gpt-auto-generator: honor read-only attribute for native rootfs, post-initrd.

Lennart Poettering lennart at poettering.net
Tue Feb 3 07:50:04 PST 2015


On Mon, 29.12.14 14:33, Dimitri John Ledkov (dimitri.j.ledkov at intel.com) wrote:

Heya,

Sorry for the late review, still busy keeping up with all the unmerged
patches and unreplied mails that queued up...

Is this issue still relevant?

> Signed-off-by: Dimitri John Ledkov <dimitri.j.ledkov at intel.com>

(We do not use S-o-b, we are not the kernel...)

>  This is not yet really ready for application, as ultimately this is
>  only solution for part of the problem.
> 
>  With this patch, post-initrd -.mount unit will have correct
>  "Options=rw" if READ_ONLY flag is not set and ro/rw was not specified
>  on the kernel cmdline. In the initrd the -.mount unit will continue
>  to be mounted ro by default (honoring cmdline rw flag, but ignoring
>  unset READ_ONLY flag).
> 
>  However, remount-fs only considers /etc/fstab and only remounts
>  things with options as specified in the /etc/fstab. Thus the fact
>  that -.mount unit changed "Options=ro" -> "Options=rw" between
>  initramfs and pivoted system does not result in the root filesystem
>  getting remounted as rw.

Hmm, what precisely is the issue again here? You are looking for a way
to make the root disk writable when using gpt auto discovery after
boot, without shipping an /etc/fstab that would result in remounting
after boot? Why wouldn't specifying "rw" on the kernel cmdline suffice
for that?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list