[systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

Andrei Borzenkov arvidjaar at gmail.com
Fri Jan 16 08:32:07 PST 2015


В Thu, 15 Jan 2015 19:24:25 -0500
Stéphane Graber <stgraber at ubuntu.com> пишет:

> @@ -871,6 +871,14 @@ static void mount_enter_unmounting(Mount *m) {
>          m->control_command_id = MOUNT_EXEC_UNMOUNT;
>          m->control_command = m->exec_command + MOUNT_EXEC_UNMOUNT;
>  
> +        /* Ignore any mounts under /dev, /proc or /sys */
> +        if (path_startswith(m->where, "/dev/") ||
> +            path_startswith(m->where, "/proc/") ||
> +            path_startswith(m->where, "/sys/")) {
> +                mount_set_state(m, MOUNT_DEAD);
> +                return;
> +        }
> +

This does not look right either. I'd rather expect to a) set
DefaultDependencies=no for these special mounts so that they are left
at shutdown and b) ignore them in the final killing spree if needed
(unless happens already).

If I as user do "systemctl stop /dev/pts" I expect it to
unmount /dev/pts not fake "dead" state.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150116/dcb92eeb/attachment-0001.sig>


More information about the systemd-devel mailing list