[systemd-devel] sd 221 regression: login - nonexistent sessions via lightdm

[poma]

Revert "login: re-use VT-sessions if they already exist" - commit 0204c4b
http://cgit.freedesktop.org/systemd/systemd/commit/?id=0204c4b

$ loginctl
   SESSION        UID USER             SEAT
        c1        989 lightdm          seat0

1 sessions listed.

$ /usr/libexec/polkit-gnome-authentication-agent-1

(polkit-gnome-authentication-agent-1:2137): polkit-gnome-1-WARNING **: Unable to determine the session we are in: No session for pid 2137

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

$ loginctl 
   SESSION        UID USER             SEAT            
        c1        989 lightdm          seat0           
         1       1001 test             seat0           

2 sessions listed.

$ ps ux | grep [a]uth
test      1850  0.0  0.4 451460 15496 ?        Sl   17:56   0:00 /usr/libexec/polkit-gnome-authentication-agent-1


Properly settles xfce-session initialized via lightdm.
---
 src/login/logind-dbus.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index 659ce18..640ae92 100644
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -690,8 +690,6 @@ static int method_create_session(sd_bus_message *message, void *userdata, sd_bus
         }
 
         manager_get_session_by_pid(m, leader, &session);
-        if (!session && vtnr > 0)
-                session = (vtnr < m->seat0->position_count) ? m->seat0->positions[vtnr] : NULL;
         if (session) {
                 _cleanup_free_ char *path = NULL;
                 _cleanup_close_ int fifo_fd = -1;
-- 
2.4.5