[systemd-devel] [PATCH] mount: don't run quotaon only for network filesystems

[Lennart Poettering]

On Mon, 30.03.15 14:42, Lukas Nykryn (lnykryn at redhat.com) wrote:

> If you havei for example ext4 on iscsi devices it is possible to setup
> qoutas there. Unfortunatelly because such fstab entry contains _netdev,
> systemd will not add dependency to quotaon.service.

I think this really needs a comment next to this in the sources,
otherwise this is likely to be changed back again the next time
somebody reworks the code, because he doesn't realize this...

Can you add a comment, please? Otherwise looks fine!

> ---
>  src/core/mount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/core/mount.c b/src/core/mount.c
> index 1251c94..f7633b7 100644
> --- a/src/core/mount.c
> +++ b/src/core/mount.c
> @@ -102,7 +102,7 @@ static bool mount_is_auto(const MountParameters *p) {
>  static bool needs_quota(const MountParameters *p) {
>          assert(p);
>  
> -        if (mount_is_network(p))
> +        if (p->fstype && fstype_is_network(p->fstype))
>                  return false;
>  
>          if (mount_is_bind(p))
> -- 
> 1.8.3.1
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Lennart

-- 
Lennart Poettering, Red Hat