[systemd-devel] [PATCH] Default to /usr/bin/u?mount, configurable, rather than hard-coded /bin/u?mount.

Lennart Poettering lennart at poettering.net
Wed May 13 06:31:21 PDT 2015


On Wed, 13.05.15 14:24, Dimitri John Ledkov (dimitri.j.ledkov at intel.com) wrote:

> On 13 May 2015 at 14:00, Lennart Poettering <lennart at poettering.net> wrote:
> > On Mon, 11.05.15 16:58, Dimitri John Ledkov (dimitri.j.ledkov at intel.com) wrote:
> >
> > Hmm, all the other AM_PATH_PROG variables do not carry a _BIN suffix,
> > should these two? I don't think so.
> >
> > (In general, I am not too big a fan of abbreviating things
> > unnecessarily, unless this is commonly done elsewhere...)
> >
> 
> There is already MOUNT define used elsewhere in the code...
> DEFINE_CAST(MOUNT, Mount);
> 
> Hence the _BIN suffix.

I see... But "_BIN" sounds weird... Please use "_PATH" then, which is
already used for some of the paths configured in Makefile.am

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list