[systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

Daurnimator quae at daurnimator.com
Wed May 27 17:27:26 PDT 2015


On 28 May 2015 at 09:58, Filipe Brandenburger <filbranden at google.com> wrote:
> Though I'm not sure whether taking a strftime format as a command line
> argument is really a good idea... But I'll defer that to other
> reviewers.

>From working with lua, I recall that accepting arbitary strftime
format strings is unsafe in general.
Behaviour for non-spec'd format specifiers is undefined.
However, all of the linux libcs handle it correctly.
==> I remember that Microsoft's libc in particular had issues.

Of course, this isn't an issue for systemd (as it's linux only), so
it's more of a theoretical concern.


More information about the systemd-devel mailing list