[systemd-devel] [PATCH 0/2] arm/aarch64: detect-virt: check dmi

[Lennart Poettering]

On Tue, 03.11.15 15:19, Andrew Jones (drjones at redhat.com) wrote:

> ARM/AArch64 guests now have SMBIOS tables populated (when boot
> with a late enough QEMU and a late enough AAVMF is used as the
> bootloader). Furthermore, when booting ARM/AArch64 guests with
> ACPI, the DT detection obviously no longer works, so we need
> dmi detection. Finally, we can now even determine KVM vs. QEMU
> as the SMBIOS contains 'KVM' in the product name, when using kvm.
> 
> The first patch in this series enables dmi detection on
> arm/aarch64. The second patch looks for KVM in the product name.
> I've only tested a backported version of these patches on an
> AArch64 guest (which worked). Of course it would be nice to get
> regression testing on all guest types that depend on dmi done.

I'd really prefer if this stuff would be in the commit msgs of the
actual patches, instead of the cover letter, as I think it's stuff
that should end up in th final repository commit.

Also, we greatly prefer patches submitted via github these days, as
that makes reviewing much easier for us.

https://github.com/systemd/systemd

Patches look fine to me in general.

Any chance you can submit all your virt detection patches as a single
PR on github?

Lennart

-- 
Lennart Poettering, Red Hat