<div dir="ltr">Hi,<div><br></div><div>This will be my first priority to either provide more information or open a bug as soon as I have time but I remember trying all the logical thoughts you are mentioning and they didn't work. I had to have both BEFORE and REQUIRED_BY dependency. Now that 198 is out, I will give it a shot again on it. Sorry for the delay.</div>
<div><br></div><div>Thanks</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 4, 2013 at 8:30 PM, Zbigniew Jędrzejewski-Szmek <span dir="ltr"><<a href="mailto:zbyszek@in.waw.pl" target="_blank">zbyszek@in.waw.pl</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Thu, Feb 14, 2013 at 09:15:28PM +0100, Zbigniew Jędrzejewski-Szmek wrote:<br>
> On Mon, Feb 04, 2013 at 05:27:24PM +0100, Umut Tezduyar wrote:<br>
> > Hi<br>
> ><br>
> > On Mon, Feb 4, 2013 at 4:23 PM, Zbigniew Jędrzejewski-Szmek <<br>
> > <a href="mailto:zbyszek@in.waw.pl">zbyszek@in.waw.pl</a>> wrote:<br>
> ><br>
> > > Hi,<br>
> > ><br>
> > > On Mon, Feb 04, 2013 at 03:03:59PM +0100, Umut Tezduyar wrote:<br>
> > > > Downside of this patch is, mountinfo mounts stick around as inactive-dead<br>
> > > > even when the file system they represent is unmounted.<br>
> > > ><br>
> > > ><br>
> > > > On Mon, Feb 4, 2013 at 3:00 PM, Umut Tezduyar <<a href="mailto:umut@tezduyar.com">umut@tezduyar.com</a>> wrote:<br>
> > > ><br>
> > > > > .mount units coming from /proc/self/mountinfo file are<br>
> > > > > unmounted after local-fs.target is reached during shutdown.<br>
> > > > ><br>
> > > > > Problem: .mount units popping up in mountinfo file are<br>
> > > > > added to systemd without any dependency. For that reason,<br>
> > > Hm, what do you mean exactly by that? Mount units I see have dependencies<br>
> > > on mount points higher in the hierarchy. E.g.<br>
> > > Requires=systemd-journald.socket -.mount home.mount<br>
> > > After=systemd-journald.socket -.mount home.mount<br>
> > > Description=/home/zbyszek/debian-x32/home<br>
> > > SourcePath=/proc/self/mountinfo<br>
> > ><br>
> ><br>
> > Mount units have dependencies on higher mount points but they do not have<br>
> > default dependencies like local-fs-pre.target, local-fs.target,<br>
> > umount.target. You can compare a mount unit coming from /etc/fstab with one<br>
> > /proc/self/mountinfo.<br>
> Hi,<br>
><br>
> I think that an addition of relationships with other units is necessary.<br>
> But adding RequiredBy=local-fs.target,Before=local-fs.target doesn't<br>
> seem to be the right combination.<br>
><br>
> Before=local-fs.target -> OK.<br>
> RequiredBy=local-fs.target -> This one doesn't seem to be necessary. In<br>
> practice there's little difference since alread-mounted mounts can't<br>
> "fail", but it's better to keep the dependency graph sparse.<br>
> Conflicts=umount.target -> I think that we want this one. Without this,<br>
> mounts added by hand will be left till the very end, but there's<br>
> no reason to make them special like this.<br>
</div></div>Ping?<br>
<br>
Zbyszek<br>
</blockquote></div><br></div>