<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 14, 2013 at 5:11 PM, Kok, Auke-jan H <span dir="ltr"><<a href="mailto:auke-jan.h.kok@intel.com" target="_blank">auke-jan.h.kok@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Oct 14, 2013 at 4:21 PM, Michael Demeter<br>
<<a href="mailto:michael.demeter@intel.com">michael.demeter@intel.com</a>> wrote:<br>
>> That's not the point, the point is is if *belongs* into the systemd<br>
>> repo, not if it's *enabled* by default or not. From what I see, it's<br>
>> nothing really we should ship upstream.<br>
><br>
> If Smack is enabled in systemd it starts very early and all of the special<br>
> devices need to be labeled properly for correct operation<br>
<br>
</div>the question isn't whether this should be udev rules or not, since<br>
that's obvious - there is no other way to set these permissions than<br>
through udev rules.<br>
<br>
the discussion is whether these should ship with the upstream systemd<br>
project, or are vendor specific and should be maintained downstream.<br>
<br>
As I explained in my other e-mail, these rules (I'm not saying they<br>
are the right ones, I'm really not that much of a udev rule expert<br>
here!) are irregardless of any policy and are useful to anyone who<br>
enables Smack, so there's a strong preference, and benefit from having<br>
these rules here, and not in a downstream project.<br>
<div class="im"><br>
>> Also, it should not repeat the primary permissions settings from the<br>
>> default rules, that is just not right.<br>
><br>
> This was done at Auke's request since the rule is adding the SECLABEL<br>
> for debugability to have the original rule present was desirable.<br>
<br>
</div>That's just me not knowing udev well, so let's remove the permissions<br>
if they just duplicate things.<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div style>Would it be preferable to replace the 50-udev-default rules completely with a Smack enabled version during the build?</div><div style><br>
</div><div style> This would then eliminate the duplication of rules.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
Auke<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Michael Demeter<div>Sr. Software Engineer</div><div>Open Source Technology Center - SSG</div><div>Intel Corporation</div>
</div></div>