<p dir="ltr">I think you might want to cast it to avoid compiler warning. Like:<br>
(void) base_filesystem_create()</p>
<div class="gmail_quote">Den 04/11/2014 17.36 skrev <<a href="mailto:harald@redhat.com">harald@redhat.com</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Harald Hoyer <<a href="mailto:harald@redhat.com">harald@redhat.com</a>><br>
<br>
Not all switch roots are like base_filesystem_create() wants them<br>
to look like. They might even boot, if they are RO and don't have the FS<br>
layout. Just ignore the error and switch_root nevertheless.<br>
<br>
base_filesystem_create() should have logged, what went wrong.<br>
---<br>
src/shared/switch-root.c | 6 +-----<br>
1 file changed, 1 insertion(+), 5 deletions(-)<br>
<br>
diff --git a/src/shared/switch-root.c b/src/shared/switch-root.c<br>
index bac0e5c..673f8a7 100644<br>
--- a/src/shared/switch-root.c<br>
+++ b/src/shared/switch-root.c<br>
@@ -103,11 +103,7 @@ int switch_root(const char *new_root, const char *oldroot, bool detach_oldroot,<br>
}<br>
}<br>
<br>
- r = base_filesystem_create(new_root);<br>
- if (r < 0) {<br>
- log_error("Failed to create the base filesystem: %s", strerror(-r));<br>
- return r;<br>
- }<br>
+ base_filesystem_create(new_root);<br>
<br>
if (chdir(new_root) < 0) {<br>
log_error("Failed to change directory to %s: %m", new_root);<br>
--<br>
2.1.0<br>
<br>
_______________________________________________<br>
systemd-devel mailing list<br>
<a href="mailto:systemd-devel@lists.freedesktop.org">systemd-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/systemd-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/systemd-devel</a><br>
</blockquote></div>